Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve printf formatter #8205

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Improve printf formatter #8205

merged 2 commits into from
Mar 19, 2024

Conversation

tautschnig
Copy link
Collaborator

See individual commit messages: fixes #7147 and #8204.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig force-pushed the bugfixes/printf branch 2 times, most recently from f14fdb8 to 7ba5ac4 Compare February 14, 2024 15:57
@tautschnig tautschnig self-assigned this Feb 14, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 63.96396% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 79.64%. Comparing base (c7d8e2e) to head (00ae5a8).

Files Patch % Lines
src/goto-programs/printf_formatter.cpp 62.61% 40 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8205      +/-   ##
===========================================
- Coverage    79.64%   79.64%   -0.01%     
===========================================
  Files         1684     1684              
  Lines       195582   195661      +79     
===========================================
+ Hits        155777   155837      +60     
- Misses       39805    39824      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig force-pushed the bugfixes/printf branch 3 times, most recently from 7862090 to f3e1e32 Compare March 19, 2024 12:07
@tautschnig
Fix printf formatting of C strings
df4668e 
We had failed to update printf formatting to accomodate
annotated_pointer_constant expressions (diffblue#6598).

Fixes: diffblue#8204
@tautschnig
Support length modifiers in printf formatting
00ae5a8 
Handle all length modifiers and conversion specifiers as laid out in
printf's man page.

Fixes: diffblue#7147
@tautschnig tautschnig requested a review from a team as a code owner March 19, 2024 14:40
@tautschnig tautschnig merged commit baaccb6 into diffblue:develop Mar 19, 2024
37 of 39 checks passed
@tautschnig tautschnig deleted the bugfixes/printf branch March 19, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterschrammel peterschrammel peterschrammel approved these changes

@kroening kroening Awaiting requested review from kroening kroening is a code owner

Assignees

@tautschnig tautschnig

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"__CPROVER_printf()" doesn't support '%ld", "%hd" and "%Lf"
3 participants
@tautschnig @peterschrammel @kroening